glenn
/
asteroid
mirror of https://github.com/glenneth1/asteroid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix toggleCountryCities bug - use let* for sequential binding 

The arrow variable was referencing country-row before it was defined
because let binds all variables simultaneously. Changed to let* for
sequential binding so country-row is available when binding arrow.
This commit is contained in:
Glenn Thompson 2025-12-15 00:02:17 +03:00 committed by Brian O'Reilly
parent 93140f8f24
commit 18c251c8c4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
parenscript/admin.lisp
View File

@ -983,9 +983,9 @@
;; Toggle city display for a country ;; Toggle city display for a country
(defun toggle-country-cities (country) (defun toggle-country-cities (country)
(let ((city-row (ps:chain document (get-element-by-id (+ "cities-" country)))) (let* ((city-row (ps:chain document (get-element-by-id (+ "cities-" country))))
(country-row (ps:chain document (query-selector (+ "tr[data-country=\"" country "\"]")))) (country-row (ps:chain document (query-selector (+ "tr[data-country=\"" country "\"]"))))
(arrow (when country-row (ps:chain country-row (query-selector ".expand-arrow"))))) (arrow (when country-row (ps:chain country-row (query-selector ".expand-arrow")))))
(if (ps:chain *expanded-countries* (has country)) (if (ps:chain *expanded-countries* (has country))
(progn (progn