glenn
/
asteroid
mirror of https://github.com/glenneth1/asteroid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Use with-error-handling macro in password APIs 

Changed password change and reset APIs to use with-error-handling
macro instead of handler-case for consistency with refactored codebase.

This ensures proper error handling using our custom condition system.
This commit is contained in:
glenneth 2025-11-03 20:23:35 +03:00
parent 356c6fbb49
commit 799a614e89
1 changed files with 38 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
auth-routes.lisp
View File

@ -110,54 +110,46 @@
(define-api asteroid/user/change-password (current-password new-password) () (define-api asteroid/user/change-password (current-password new-password) ()
"API endpoint for users to change their own password" "API endpoint for users to change their own password"
(require-authentication) (require-authentication)
(handler-case (with-error-handling
(if (and current-password new-password) (if (and current-password new-password)
(let* ((current-user (auth:current-user)) (let* ((current-user (auth:current-user))
(username (gethash "username" current-user)) (username (gethash "username" current-user))
(stored-hash (gethash "password-hash" current-user))) (stored-hash (gethash "password-hash" current-user)))
;; Verify current password ;; Verify current password
(if (verify-password current-password (if (verify-password current-password
(if (listp stored-hash) (first stored-hash) stored-hash)) (if (listp stored-hash) (first stored-hash) stored-hash))
;; Current password is correct, update to new password ;; Current password is correct, update to new password
(if (reset-user-password username new-password) (if (reset-user-password username new-password)
(api-output `(("status" . "success") (api-output `(("status" . "success")
("message" . "Password changed successfully"))) ("message" . "Password changed successfully")))
(api-output `(("status" . "error") (api-output `(("status" . "error")
("message" . "Failed to update password")) ("message" . "Failed to update password"))
:status 500)) :status 500))
;; Current password is incorrect ;; Current password is incorrect
(api-output `(("status" . "error") (api-output `(("status" . "error")
("message" . "Current password is incorrect")) ("message" . "Current password is incorrect"))
:status 401))) :status 401)))
(api-output `(("status" . "error") (api-output `(("status" . "error")
("message" . "Missing required fields")) ("message" . "Missing required fields"))
:status 400)) :status 400))))
(error (e)
(api-output `(("status" . "error")
("message" . ,(format nil "Error changing password: ~a" e)))
:status 500))))
;; API: Reset user password (admin only) ;; API: Reset user password (admin only)
(define-api asteroid/admin/reset-password (username new-password) () (define-api asteroid/admin/reset-password (username new-password) ()
"API endpoint for admins to reset any user's password" "API endpoint for admins to reset any user's password"
(require-role :admin) (require-role :admin)
(handler-case (with-error-handling
(if (and username new-password) (if (and username new-password)
(let ((user (find-user-by-username username))) (let ((user (find-user-by-username username)))
(if user (if user
(if (reset-user-password username new-password) (if (reset-user-password username new-password)
(api-output `(("status" . "success") (api-output `(("status" . "success")
("message" . ,(format nil "Password reset for user: ~a" username)))) ("message" . ,(format nil "Password reset for user: ~a" username))))
(api-output `(("status" . "error") (api-output `(("status" . "error")
("message" . "Failed to reset password")) ("message" . "Failed to reset password"))
:status 500)) :status 500))
(api-output `(("status" . "error") (api-output `(("status" . "error")
("message" . ,(format nil "User not found: ~a" username))) ("message" . ,(format nil "User not found: ~a" username)))
:status 404))) :status 404)))
(api-output `(("status" . "error") (api-output `(("status" . "error")
("message" . "Missing required fields")) ("message" . "Missing required fields"))
:status 400)) :status 400))))
(error (e)
(api-output `(("status" . "error")
("message" . ,(format nil "Error resetting password: ~a" e)))
:status 500))))