From 9ab4e6c3836fe7859816622890282bfc10ba52a5 Mon Sep 17 00:00:00 2001 From: Glenn Thompson Date: Wed, 1 Oct 2025 20:57:18 +0300 Subject: [PATCH] fix: Revert unnecessary Docker image change - Keep original savonet/liquidsoap:792d8bf (Liquidsoap 2.4.1+git) - Original image already includes FDK-AAC encoder support - No need to downgrade to v2.2.5 - Update documentation to reflect correct information The original 792d8bf commit corresponds to Liquidsoap 2.4.1+git which already has liquidsoap.build_config.optionals.fdkaac available. --- AAC-STREAMING.md | 15 +++++++++------ docker/Dockerfile.liquidsoap | 4 ++-- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/AAC-STREAMING.md b/AAC-STREAMING.md index e9e9936..2bc3b40 100644 --- a/AAC-STREAMING.md +++ b/AAC-STREAMING.md @@ -15,9 +15,10 @@ This branch adds AAC (Advanced Audio Coding) streaming support to Asteroid Radio - **AAC set as default** (recommended option) ### ⚙️ **Technical Implementation** + - **Liquidsoap real-time transcoding** from MP3 files to AAC -- **FDK-AAC encoder** via `%fdkaac()` function -- **Updated Docker image** to `savonet/liquidsoap:v2.2.5` for AAC support +- **FDK-AAC encoder** via `%fdkaac()` function +- **Existing Docker image** `savonet/liquidsoap:792d8bf` already includes AAC support ## Stream URLs @@ -76,10 +77,12 @@ output.icecast( ) ``` -### **Docker Updates** -- Updated base image from `savonet/liquidsoap:792d8bf` to `savonet/liquidsoap:v2.2.5` -- Includes FDK-AAC encoder support -- Maintains backward compatibility with existing MP3 streams +### **Docker Configuration** + +- Uses existing `savonet/liquidsoap:792d8bf` image (Liquidsoap 2.4.1+git) +- FDK-AAC encoder already included and supported +- No Docker image changes required +- Maintains full backward compatibility with existing MP3 streams ### **Web Interface Updates** - Added stream quality selector with JavaScript switching diff --git a/docker/Dockerfile.liquidsoap b/docker/Dockerfile.liquidsoap index 9529b4b..224ac7a 100644 --- a/docker/Dockerfile.liquidsoap +++ b/docker/Dockerfile.liquidsoap @@ -1,5 +1,5 @@ -# Use official Liquidsoap Docker image with AAC support -FROM savonet/liquidsoap:v2.2.5 +# Use official Liquidsoap Docker image from Savonet team +FROM savonet/liquidsoap:792d8bf # Switch to root for setup USER root