glenn
/
asteroid
mirror of https://github.com/glenneth1/asteroid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Revert Liquidsoap bind address to 0.0.0.0 

As easilok correctly pointed out in IRC:
- Inside container: Liquidsoap must bind to 0.0.0.0 (all interfaces)
- Security is enforced by Docker port mapping: 127.0.0.1🔢1234
- This prevents external access while allowing container functionality

The docker-compose.yml mapping is what provides security, not the
bind address inside the container.

Credit: easilok for the explanation and fix approach
This commit is contained in:
glenneth 2025-11-03 20:44:28 +03:00
parent 9047414ecd
commit cb13bc9cfd
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docker/asteroid-radio-docker.liq
View File

@ -15,10 +15,11 @@ settings.frame.audio.channels.set(2)
settings.audio.converter.samplerate.libsamplerate.quality.set("best") settings.audio.converter.samplerate.libsamplerate.quality.set("best")
# Enable telnet server for remote control # Enable telnet server for remote control
# Bind to 127.0.0.1 for security (only accessible from within container) # Bind to 0.0.0.0 inside container (Docker port mapping restricts external access)
# Security is enforced by docker-compose.yml: "127.0.0.1:1234:1234"
settings.server.telnet.set(true) settings.server.telnet.set(true)
settings.server.telnet.port.set(1234) settings.server.telnet.port.set(1234)
settings.server.telnet.bind_addr.set("127.0.0.1") settings.server.telnet.bind_addr.set("0.0.0.0")
# Get Icecast source password from environment variable # Get Icecast source password from environment variable
# Falls back to default if not set (for development) # Falls back to default if not set (for development)